Implement new space selector bottom sheet #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- First implementation
- Apply search query to the recents section
- Root space list from MXSpaceService
- Code tweaks
…Implement_new_Space_selector_bottom_sheet
- update after code review
- Changed MXRecentsRoomListDataFetcher to MXBreadcrumbsRoomListDataFetcher
- Added change log
…Implement_new_Space_selector_bottom_sheet
Codecov Report
@@ Coverage Diff @@
## develop #1541 +/- ##
===========================================
+ Coverage 34.67% 42.11% +7.43%
===========================================
Files 515 515
Lines 84105 84113 +8
Branches 37104 37062 -42
===========================================
+ Hits 29166 35424 +6258
+ Misses 54027 47655 -6372
- Partials 912 1034 +122
Continue to review full report at Codecov.
|
- Added change log
gileluard
deleted the
gil/6410-Implement_new_Space_selector_bottom_sheet
branch
13027776717
added a commit
to 13027776717/matrix-ios-sdk
that referenced
this pull request
Aug 29, 2022
* release/nodefy_0.23.15: (175 commits) finish version++ version++ Stop using the room ID from the space child state. finish version++ version++ MXBeaconAggregations: Add debug log when MXBeaconInfoSummary associated to a stopped beacon info is not found. Implement new space selector bottom sheet (matrix-org#1541) Rooms without an unread badge show up in "unread" tab (matrix-org#1540) Delight edit layout experiment (matrix-org#1515) Send an empty dictionary when calling /join to be spec compliant. Empty commit to wake codecov AllWorkingTests: Disable tests that do not pass on GH actions changelog AllWorkingTests: Disabled commented tests Crypto tests CI: Expose tests report on failure and share code coverage Tests: Run working integration tests on every PR AllWorkingTests: Disable all unit tests AllWorkingTests: Disable the 22 tests that fail AllWorkingTests: Disable test classes with tests that crash Tests: Create AllWorkingTests test plan with stable tests ... # Conflicts: # MatrixSDK/Data/RoomSummaryStore/CoreData/Models/MXRoomSummaryMO.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for element-hq/element-ios#6410